feat: remove visibilityjs #10870
Merged
feat: remove visibilityjs #10870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💡 Friendly NoteThis pull request was made against the
Thanks! |
|
LGTM |
julianlam
reviewed
Aug 29, 2022
Comment on lines
-22
to
+25
| app.isFocused = true; | ||
| Object.defineProperty(app, 'isFocused', { | ||
| get() { | ||
| return document.visibilityState === 'visible'; | ||
| } | ||
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a now unnecessary dependency.
Instead
app.isFocusedis just a getter returningtrueifdocument.visibilityStateis equal tovisible. This also means one NodeBB is listening on one less event :)