Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open topic thumbs in dialog instead of in same tab #11416

Merged
merged 1 commit into from Apr 26, 2023
Merged

Open topic thumbs in dialog instead of in same tab #11416

merged 1 commit into from Apr 26, 2023

Conversation

julianlam
Copy link
Member

@julianlam julianlam commented Mar 29, 2023 •
edited

thumbs.mp4

@nodebb-misty
Copy link
Contributor

💡 Friendly Note

This pull request was made against the develop branch, which is reserved for commits destined for a minor or major release.If your commits simply fixes a bug, please rebase this PR against the master instead.

  • patch releases — bug fixes only
  • minor releases — new features, enhancements, and bug fixes
  • major releases — breaking changes, including all of the above

Thanks!

@julianlam
Copy link
Member Author

For merging in for v3.1.0

@julianlam julianlam added this to the 3.1.0 milestone Mar 29, 2023
@julianlam julianlam mentioned this pull request Mar 30, 2023
Closed
@julianlam julianlam merged commit 04219c4 into develop Apr 26, 2023
15 checks passed
@julianlam julianlam deleted the modal-for-thumbs branch April 26, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julianlam @nodebb-misty