fix: NodeBB#11482 thumbs Post Can not upload a thumbnail, only multip…

[Veronikya]

…le uploads

[CLAassistant]

All committers have signed the CLA.

[barisusakli]

@Veronikya thanks for this, can you remove this line https://github.com/NodeBB/NodeBB/blob/master/test/helpers/index.js#L124,
lets see if all tests pass without it. Since your code should handle objects and turn it into an array 🤔

[barisusakli]

Can get rid of the /2 here as well https://github.com/NodeBB/NodeBB/blob/master/test/uploads.js#L90-L91 since we don't upload x2 files anymore

[barisusakli]

You don't have to get rid of it just changing that line and removing /2 should make it pass I think.

[barisusakli]

Should be const times = (meta.config.uploadRateLimitThreshold) + 1; instead of const times = (meta.config.uploadRateLimitThreshold / 2) + 1;

[Veronikya]

assert.strictEqual(orphans.length, 1);
It looks like this, the quantity does not match
:)

[barisusakli]

Lgtm will merge later today