Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: docker improvements #12031

Merged
merged 44 commits into from
Nov 12, 2023
Merged

feat: docker improvements #12031

merged 44 commits into from
Nov 12, 2023

Commits on Sep 23, 2023

  1. use yarn and debian slim build

    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    bd8b2eb View commit details
    Browse the repository at this point in the history

  2. feat: update Dockerfile to use multistage builds

    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    40827fd View commit details
    Browse the repository at this point in the history

  3. Create main.yml

    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    5710dbb View commit details
    Browse the repository at this point in the history

  4. remove some useless things from docker context and assume yarn by def… 

    …ault
    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    06ab160 View commit details
    Browse the repository at this point in the history

  5. remove all dotfiles in docker context

    @stevefan1999 @oplik0
    stevefan1999 authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    1c7faf1 View commit details
    Browse the repository at this point in the history

  6. no need for extra build tools, complain to the module author if there… 

    … is no alpine build

(cherry picked from commit 90516a3)
    @stevefan1999 @oplik0
    stevefan1999 authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    9a61d65 View commit details
    Browse the repository at this point in the history

  7. specify the config file location instead of creating it 

    (cherry picked from commit 38e4295)
    @stevefan1999 @oplik0
    stevefan1999 authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    cf0678d View commit details
    Browse the repository at this point in the history

  8. set explicit config path 

    (cherry picked from commit 8dcc6f2)
    @stevefan1999 @oplik0
    stevefan1999 authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    f8c6495 View commit details
    Browse the repository at this point in the history

  9. fix docker-compose example to use the exposed volumes

    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    43f1592 View commit details
    Browse the repository at this point in the history

  10. dockerfile: upgrade alpine to 3.16

    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    cb1e7f4 View commit details
    Browse the repository at this point in the history

  11. dockerignore: add more ignorable entries

    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    4a4c2e1 View commit details
    Browse the repository at this point in the history

  12. docker-compose: change the way the docker startup process works

    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    431716c View commit details
    Browse the repository at this point in the history

  13. install: pass config path to child process as well 

    Signed-off-by: steve <29133953+stevefan1999-personal@users.noreply.github.com>
    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    f3b9a53 View commit details
    Browse the repository at this point in the history

  14. setup: move config file resolution up before setup 

    This fixes issue with different config file location, which will otherwise default on 'config.json', which means the config save won't save to the file we specified

Signed-off-by: steve <29133953+stevefan1999-personal@users.noreply.github.com>
    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    f1025a6 View commit details
    Browse the repository at this point in the history

  15. docker-entrypoint: don't fix CONFIG_DIR location but fix default loca… 

    …tion

Signed-off-by: steve <29133953+stevefan1999-personal@users.noreply.github.com>
    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    df80664 View commit details
    Browse the repository at this point in the history

  16. docker-entrypoint: handle missing config file logic 

    Signed-off-by: steve <29133953+stevefan1999-personal@users.noreply.github.com>
    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    a26926f View commit details
    Browse the repository at this point in the history

  17. README: add simple notice on how to use it 

    Signed-off-by: steve <29133953+stevefan1999-personal@users.noreply.github.com>
    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    0f95faf View commit details
    Browse the repository at this point in the history

  18. add missing semicolons 

    Signed-off-by: steve <29133953+stevefan1999-personal@users.noreply.github.com>
    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    3ae3205 View commit details
    Browse the repository at this point in the history

  19. docker-compose: remove multi override, use one big profile instead 

    However, Docker Compose doesn't support profile-based dependency and this would probably means we have less guarantee about the liveness of the database. But since this is just a sample configuration it should be fine

Signed-off-by: steve <29133953+stevefan1999-personal@users.noreply.github.com>
    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    51db0e8 View commit details
    Browse the repository at this point in the history

  20. workflows: remove main.yml, add platforms to buildx matrix in docker.yml 

    Signed-off-by: steve <29133953+stevefan1999-personal@users.noreply.github.com>
    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    8c7c8db View commit details
    Browse the repository at this point in the history

  21. workflows: set docker buildx to build for amd64 and arm64 only 

    Signed-off-by: steve <29133953+stevefan1999-personal@users.noreply.github.com>
    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    61ef6cb View commit details
    Browse the repository at this point in the history

  22. docker-entrypoint: don't force build everytime before start 

    Signed-off-by: steve <29133953+stevefan1999-personal@users.noreply.github.com>
    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    8e96c1e View commit details
    Browse the repository at this point in the history

  23. docker-entrypoint: implement init verb 

    This would allow you to change between "setup" (automated setup using environmental variables which is the current preferred way to run containerized NodeBB) or "install" (web install that guides user to fill in connection information, which is similar to WordPress)

Signed-off-by: steve <29133953+stevefan1999-personal@users.noreply.github.com>
    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    86d6f9a View commit details
    Browse the repository at this point in the history

  24. README: mention caveat with MongoDB 

    Signed-off-by: steve <29133953+stevefan1999-personal@users.noreply.github.com>
    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    40fc8cd View commit details
    Browse the repository at this point in the history

  25. README: add Docker section placeholder for doc migration 

    Signed-off-by: steve <29133953+stevefan1999-personal@users.noreply.github.com>
    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    14981a0 View commit details
    Browse the repository at this point in the history

  26. docker-entrypoint: add SETUP variable support 

    Signed-off-by: steve <29133953+stevefan1999-personal@users.noreply.github.com>
    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    9c0e2bd View commit details
    Browse the repository at this point in the history

  27. docker-compose: add force flag to ln on setup 

    Signed-off-by: steve <29133953+stevefan1999-personal@users.noreply.github.com>
    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    9cbf58f View commit details
    Browse the repository at this point in the history

  28. docker-compose: fix permission issue; docker-compose: fast exit if st… 

    …ill no permission on config dir

Signed-off-by: steve <29133953+stevefan1999-personal@users.noreply.github.com>
    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    2829427 View commit details
    Browse the repository at this point in the history

  29. fix: remove redundant FROM

    @stevefan1999-personal @oplik0
    stevefan1999-personal authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    021b4f1 View commit details
    Browse the repository at this point in the history

  30. docs: remove docker stuff (in favour of docs entry, NodeBB/docs#78) b… 

    …ut add link to cloud install docs
    @julianlam @oplik0
    julianlam authored and oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    4172224 View commit details
    Browse the repository at this point in the history

  31. fix: correctly check if directory is writable

    @oplik0
    oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    c0aafa9 View commit details
    Browse the repository at this point in the history

  32. fix: ignore .docker directory

    @oplik0
    oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    28cf4f2 View commit details
    Browse the repository at this point in the history

  33. fix: multi-arch docker builds and chown performance

    @oplik0
    oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    373e26b View commit details
    Browse the repository at this point in the history

  34. chore: bump database image versions

    @oplik0
    oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    4b14bd9 View commit details
    Browse the repository at this point in the history

  35. fix: move from alpine to slim image

    @oplik0
    oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    552f19d View commit details
    Browse the repository at this point in the history

  36. fix: use omit=dev instead of only=prod

    @oplik0
    oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    bbc1df1 View commit details
    Browse the repository at this point in the history

  37. feat: move entrypoint to install directory

    @oplik0
    oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    6bd69ec View commit details
    Browse the repository at this point in the history

  38. feat: initialize mongodb user

    @oplik0
    oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    f5d5d79 View commit details
    Browse the repository at this point in the history

  39. feat: use separate rebuild stage

    @oplik0
    oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    80854e5 View commit details
    Browse the repository at this point in the history

  40. fix: disable eslint for mongodb script

    @oplik0
    oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    54bea3c View commit details
    Browse the repository at this point in the history

  41. fix: remove node_modules bind mount 

    bind mounts don't save data from container, resulting in a LOONG startup
    @oplik0
    oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    416e856 View commit details
    Browse the repository at this point in the history

  42. feat: prepopulate database defaults for installation

    @oplik0
    oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    a44187d View commit details
    Browse the repository at this point in the history

  43. feat: enable persistence in redis container

    @oplik0
    oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    40e806b View commit details
    Browse the repository at this point in the history

  44. docs: add some comments to the compose file

    @oplik0
    oplik0 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    9d21da8 View commit details
    Browse the repository at this point in the history