anyway we can enable a force delete even on an Admin? #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason that's needed is for the importer, to be able to purge all categories and delete all users (except the original admin) Also, in `User.delete` any reason `deletePosts` and `deleteTopics` occur after `deleteAccount` ? I switched them, I figured if an admin is trying to delete another admin, if should throw the error before emptying all of its posts and topics, no ?
|
I think you meant before deleteAccount, also I think moving that check higher up is the way to go. So that the importer can just call User.delete. |
|
Check out my commit does that solve your problem? |
|
that'll do it! thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason that's needed is for the importer, to be able to purge all categories and delete all users (except the original admin) and restart the process.
Also, in
User.deleteany reasondeletePostsanddeleteTopicsoccur afterdeleteAccount? I switched them, I figured if an admin is trying to delete another admin, if should throw the error before emptying all of its posts and topics, no ?