add static:assets.prepare hook #4889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add static:assets.prepare hook to be called before css minification so that themes/plugins can modify less vars.
| @@ -85,6 +85,7 @@ function initializeNodeBB(callback) { | |||
| function(next) { | |||
| plugins.init(app, middleware, next); | |||
| }, | |||
| async.apply(plugins.fireHook, 'static:assets.prepare', []), | |||
There was a problem hiding this comment.
I don't think you need to pass anything in, do you? (Re: the [])
There was a problem hiding this comment.
the theme right now does not pass anything to NodeBB so yeah it can be removed.
There was a problem hiding this comment.
Right. NodeBB doesn't do anything with the returned data, actually. It's just for plugins to consume. In this case, it can be removed... or rather, replaced with {}, since core expects a parameter here.
There was a problem hiding this comment.
should be good to go.
|
👍 |
BenLubar
added a commit
to boomzillawtf/tdwtf
that referenced
this pull request
Jul 27, 2016
…eBB/NodeBB#4892> - allowing widgets to not show up if widget explicitly returns null <NodeBB/NodeBB@a9a522c> - add static:assets.prepare hook <NodeBB/NodeBB#4889>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add static:assets.prepare hook to be called before css minification so that themes/plugins can modify less vars.