Handle callback errors #4951
Merged
Handle callback errors #4951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The linting process is failing on travis for node versions < 4. ESLint requires at least node version 4, as it uses some ES2015 features. |
|
Can you make the eslint addition a separate PR so we can merge the callback additions? Also you can just use |
| var db = require('./src/database'); | ||
|
|
||
| db.getSortedSetRange('plugins:active', 0, -1, function(err, plugins) { | ||
| if (err) { |
|
@barisusakli Thanks for the code review. I addressed most of the concerns you mentioned, except for one, where I posted a follow-up question. Apart from that, I also removed the ESLint part from this PR. I will create a separate PR for this 😉. |
BenLubar
added a commit
to boomzillawtf/tdwtf
that referenced
this pull request
Aug 20, 2016
- Resolve two DoS attack vectors <NodeBB/NodeBB#4949> - Fix the thing that caused 502s last time there was an update <NodeBB/NodeBB@3161879> - Admins can now attack the tag cloud <NodeBB/NodeBB#4795> - Logging in/out with multiple tabs open is less buggy <NodeBB/NodeBB#4950> - Fixed the timestamp not being set on replies <NodeBB/NodeBB@3b0eca3> - Fixed unnecessary page refresh when going to replied-to posts <NodeBB/NodeBB@9207d6a> - Purged topics are removed from the followed topics set <NodeBB/NodeBB#4955> - Fixed a bunch of unhandled errors <NodeBB/NodeBB#4951> - Fixed breadcrumb for account info page <NodeBB/NodeBB#4958> - Moved login session list to the account info page <NodeBB/NodeBB#4959> <NodeBB/nodebb-theme-persona#310> - Got rid of error messages about malformed URLs in the server log <NodeBB/NodeBB#4954> - **HEY GUYS they fixed "new posts made to topic" notifications going to the end of the topic** <NodeBB/NodeBB#4469>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging a failing test I’ve noticed that there was an unhandled callback error in the failing test. I spent a lot of time to figure out why the assertion was failing, but the data, used in the assertion, was not present at all due to a previous error.
I’ve added eslint and enabled to rule
handle-callback-errwhich can detect some unhandled errors statically. ESLint found round about 100 unhandled errors in the whole project.I tried to fix this and handle all errors properly. In some cases I was not sure if an error was ignored intentionally. So please review these changes carefully and let me know if there is such an case where the error should be ignored. Nevertheless, even if an error should be ignored I think we should at least log the error with winston.