fix: #7444 Re-factor handling of og:image tags #7463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated logic to set additional og:image tags based on more factors - logo.png fallback
julianlam
commented
Mar 16, 2019
| // Returns array of this post's uploads | ||
| db.getSortedSetRange('post:' + pid + ':uploads', 0, -1, callback); | ||
| }; | ||
|
|
||
| Posts.uploads.listWithSizes = async function (pid) { | ||
| const paths = await Posts.async.uploads.list(pid); | ||
| const sizes = await db.getObjects(paths.map(path => 'upload:' + md5(path))); | ||
| const sizes = await db.async.getObjects(paths.map(path => 'upload:' + md5(path))); |
There was a problem hiding this comment.
@barisusakli I experienced an issue here. If at top of file I require('../database').async, then later on in the file, console.log(db); was undefined if called from inside Posts.upload.list.
I ended up fixing it by doing db.async when used inside the file instead.
Just to give you some context, the upgrade script I was writing was calling await Posts.uploads.list(), and erroring out as db was undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new logic will supply
og:imagetags in the following order:og:imageif set in ACP, otherwise,brand:logoif set in ACP, otherwise/logo.pngA provided upgrade script will calculate sizes for all uploads tracked in NodeBB (if they're associated with a post, that is), and will then insert the appropriate
og:image:heightandog:image:widthtags.