fix: do not overwrite config.port from URL, if it's already set
#9305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If URL was set to something like `http://example.com:8080`, and port was set to 4567, keep listening on port 4567 and keep linking through URL that was specified. This allows to listen on port 4567, while having NGINX (or any proxy) set to listen on port 8080 and route traffic to port 4567. So NodeBB can be "hidden" behind proxy while URL can still contain non-standard port, i.e., port different than 80 and 443.
|
|
|
Hm... changing it here seems to not be the correct approach, I think. If I understand your use case correctly, you want to have NodeBB listen on port 4567, but have the URL set to |
|
Nevermind, I am mistaken, NodeBB does handle it correctly on startup, your change is fixing the overwrite on the install step 👍 |
julianlam
approved these changes
Feb 17, 2021
julianlam
added a commit
that referenced
this pull request
Feb 17, 2021
|
Yes, only setup was overwriting my config. After config is fixed, everything works just fine :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If URL was set to something like
http://example.com:8080, and portwas set to 4567, keep listening on port 4567 and keep linking through
URL that was specified.
This allows to listen on port 4567, while having NGINX (or any proxy)
set to listen on port 8080 and route traffic to port 4567.
So NodeBB can be "hidden" behind proxy while URL can still contain
non-standard port, i.e., port different than 80 and 443.