Feat: Client-side hooks - replace window.trigger

[Antosik]

Done:

• All $(window).trigger entries were replaced by hooks.fire

[julianlam]

Oh! Wow, okay 😁

Do you want to work for NodeBB?

[barisusakli]

Replacing
$(window).trigger with

require(['hooks'], function (hooks) {
   hooks.trigger()
});

Sometimes causes issues when the load order is important. So it's best to require hooks at the top of the file.

[psychobunny]

nice 👍 I think this require can be removed?

NodeBB/public/src/app.js

Lines 63 to 71 in 42c164f

	require(['hooks'], function (hooks) {
	hooks.on('action:ajaxify.end', function () {
	document.body.removeEventListener('click', earlyClick);
	earlyQueue.forEach(function (el) {
	el.click();
	});
	earlyQueue = [];
	});
	});

[Antosik]

I think this require can be removed? (NodeBB/public/src/app.js#63-71)

I tried to remove it but it causes an error. app.handleEarlyClicks is called right after it was defined and hooks module isn't ready yet.