Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update highlight.js #77

Closed
uidHUB opened this issue Jun 22, 2016 · 5 comments
Closed

Update highlight.js #77

uidHUB opened this issue Jun 22, 2016 · 5 comments
Assignees
@julianlam

Comments

@uidHUB
Copy link

uidHUB commented Jun 22, 2016

Hi! How update highlight.js to latest version?
I replace /public/js/highlight.js to v9.4, it working. But browser console give me error:

nodebb.min.js > Uncaught Error: Mismatched anonymous define() module: function (){return t.hljs}
http://requirejs.org/docs/errors.html#mismatch

HighlightJS v9.4 support require.js, but i not know how connect this version to NodeBB.
@julianlam
Copy link
Member

Thanks, will take a look today

@julianlam julianlam self-assigned this Jun 22, 2016
@julianlam
Copy link
Member

I added highlight.js years ago, so there's probably a better way to include the lib now.

@uidHUB
Copy link
Author

uidHUB commented Jun 22, 2016

@julianlam I think this will cause an error request.js. I will try code and report.

@uidHUB
Copy link
Author

uidHUB commented Jun 22, 2016

@julianlam work fine!

I think this will cause an error request.js

I do not know much NodeBB. :)

@julianlam
Copy link
Member

👍

BenLubar added a commit to boomzillawtf/tdwtf that referenced this issue Jun 23, 2016
@BenLubar
- Fixed: mark all read doesn't hide pagination <NodeBB/NodeBB#4779>
71a50e9 
- Fixed: Group name change does not complete if group is hidden <NodeBB/NodeBB#4775>
- Fixed: When group is renamed, the admin page should send user to the new route <NodeBB/NodeBB#4776>
- Fixed: Update highlight.js <NodeBB/nodebb-plugin-markdown#77>
- Fixed: Restoring the composer from maximized state does not save the composer height<NodeBB/nodebb-plugin-composer-default#42>
- design changes for composer on mobile <NodeBB/nodebb-plugin-composer-default#44>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julianlam julianlam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julianlam @uidHUB