Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group name change does not complete if group is hidden #4775

Closed
julianlam opened this issue Jun 21, 2016 · 0 comments
Closed

Group name change does not complete if group is hidden #4775

julianlam opened this issue Jun 21, 2016 · 0 comments
Assignees
@barisusakli
Labels
bug low priority
Milestone
1.1.0

Comments

@julianlam
Copy link
Member

Re: https://github.com/NodeBB/NodeBB/blob/master/src/groups/update.js#L171

If the group is hidden, group change does not take place. I am ok to remove this condition, though I don't understand why it was checking for both to begin with.

Original renameGroup method here: 8113ed6

So I'll need @barisusakli to look over and see if it is safe to remove the check for hidden groups.
@julianlam julianlam added this to the 1.1.0 milestone Jun 21, 2016
BenLubar added a commit to boomzillawtf/tdwtf that referenced this issue Jun 23, 2016
@BenLubar
- Fixed: mark all read doesn't hide pagination <NodeBB/NodeBB#4779>
71a50e9 
- Fixed: Group name change does not complete if group is hidden <NodeBB/NodeBB#4775>
- Fixed: When group is renamed, the admin page should send user to the new route <NodeBB/NodeBB#4776>
- Fixed: Update highlight.js <NodeBB/nodebb-plugin-markdown#77>
- Fixed: Restoring the composer from maximized state does not save the composer height<NodeBB/nodebb-plugin-composer-default#42>
- design changes for composer on mobile <NodeBB/nodebb-plugin-composer-default#44>
@snyk-bot snyk-bot mentioned this issue Jan 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barisusakli barisusakli

Labels
bug low priority
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@julianlam @barisusakli