Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra events needed in hh-tracer #297

Closed
Tracked by #299
fvictorio opened this issue Feb 22, 2024 · 0 comments
Closed
Tracked by #299

Add extra events needed in hh-tracer #297

fvictorio opened this issue Feb 22, 2024 · 0 comments
Assignees
Milestone

Comments

@fvictorio
Copy link
Member

fvictorio commented Feb 22, 2024

Besides the beforeMessage, step, and afterMessage events, hardhat-tracer uses the beforeTx, afterTx and newContract events, so we should add them. I think the first two are going to be easy and only need changes in the Hardhat side; the newContract one seems harder.

Definition of done

The following events can be used. As with the events we have now, we don't need to pass the same data as ethereumjs; a partial object with just the fields needed by hh-tracer is enough:

  • vm.events.on("beforeTx", ...)
  • vm.events.on("afterTx", ...)
  • vm.evm.events.on("newContract", ...)
@fvictorio fvictorio assigned Wodann and fvictorio and unassigned Wodann Feb 22, 2024
@fvictorio fvictorio changed the title Add extra events needed in hh-tracer (BE) Add extra events needed in hh-tracer Feb 26, 2024
@Wodann Wodann added this to the EDR v0.2.0 milestone Feb 26, 2024
@fvictorio fvictorio changed the title (BE) Add extra events needed in hh-tracer Add extra events needed in hh-tracer Mar 13, 2024
@Wodann Wodann modified the milestones: EDR v0.2.0, EDR v0.4.0 Mar 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants