Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large output is a reality, and killing the subprocess is not a workaround #51

Closed
lars-t-hansen opened this issue Jun 21, 2023 · 2 comments
Assignees

Comments

@lars-t-hansen
Copy link
Collaborator

Basically, running ps on "big enough" systems or asking for the unfiltered ps output will create enough output to make the pipe fill up and the process hang, in turn causing the subprocess to be killed by the timeout in command.rs: #50 (comment).

There are really two bugs here. One is that if the subprocess is killed there should be some report up the call chain so that whoever started the process can take evasive action, log an error, etc. (In general there are probably good reasons why we should try to catch errors high up and log them.) The other is that we need to fix the hangs caused by too-large output.

@lars-t-hansen lars-t-hansen self-assigned this Jun 21, 2023
@lars-t-hansen
Copy link
Collaborator Author

Propagating errors from command.rs moved to #53, proper logging moved to #52, the present bug is about handling large output from the subcommand.

@bast
Copy link
Member

bast commented Jun 22, 2023

Thanks! I am sorry because I knew about this problem but did not document it properly. Reviewing this and other PRs ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants