Fixes #15126: Add verbosity level in the rudder logger #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
reviewed
Aug 8, 2019
tree/20_cfe_basics/log_rudder.cf
Outdated
| # @name Log for Rudder with mode | ||
| # @description Logging different verbosity outputs for Rudder reports | ||
| # | ||
| # @parameter mode The mode use to make the report (can be info, normal, debug) |
There was a problem hiding this comment.
normal is a weird verbosity level
ncharles
reviewed
Aug 8, 2019
| methods: | ||
| # Report using the appropriate bundle(s) | ||
| "wrapper for ${configuration.enabled_loggers}" | ||
| usebundle => log_rudder_mode("${mode}", "${message}", "${class_parameter}", "${old_class_prefix}", "${class_prefix}", "@{args}"), |
There was a problem hiding this comment.
in 5.1, ncf cannot be standalone anymore.
do we really need this method ? can't we simply use the log_rudder_mode ?
or do you expect that we need some layer of indirection for the future ?
There was a problem hiding this comment.
You are definitely right, we do not need another layer of indirection, this will only make things less understandable.
…configurable_ncf_pr'
Fdall
force-pushed
the
ust_15126/add_verbosity_level_in_the_rudder_logger
branch
from
eea442e
to
b9c0f39
Compare
|
retarget to 5.1, too much diff to do, I will recreate a pull request starting in 5.1 |
|
new PR here: #1048 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/15126