Fixes #15126: Add verbosity level in the rudder logger #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fdall
force-pushed
the
ust_15126/add_verbosity_level_in_the_rudder_logger
branch
from
29562a5
to
303788a
Compare
|
Commit modified |
Fdall
force-pushed
the
ust_15126/add_verbosity_level_in_the_rudder_logger
branch
from
303788a
to
a3d60a2
Compare
|
Commit modified |
ncharles
reviewed
Aug 22, 2019
tree/20_cfe_basics/log_rudder.cf
Outdated
| # | ||
| # If the parameter mode is not in the list above, it will report in a classical manner | ||
| # based on the reporting context and the defined classes. |
There was a problem hiding this comment.
I'm really confused on how it should work: it has a class prefix, that it won't use to get the _repaired, _success, _failure, so the message will also be not be customized
why not simply having a
bundle agent log_rudder_mode(mode, message, class_parameter, class_prefix) ?
signature will only expose what's relevant, and make it easier to use.
Fdall
force-pushed
the
ust_15126/add_verbosity_level_in_the_rudder_logger
branch
from
a3d60a2
to
70f771e
Compare
|
Commit modified |
Fdall
force-pushed
the
ust_15126/add_verbosity_level_in_the_rudder_logger
branch
from
70f771e
to
0facce9
Compare
|
Commit modified |
ncharles
approved these changes
Nov 15, 2019
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/15126