Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #16226: Error when importing technique with missing component in a method call #1112

Conversation

VinceMacBuche
Copy link
Member

@Normation-Quality-Assistant
Copy link
Contributor

This PR breaks qa-test

-- stdout -- 
Branch 'branches/rudder/5.0' set up to track remote branch 'branches/rudder/5.0' from 'NRM'.
Your branch is up to date with 'NRM/branches/rudder/5.0'.
Already up to date.
Already up to date.
[...]
-- stderr --
From github.com:VinceMacBuche/ncf
 * [new branch]      bug_16226/error_when_importing_technique_with_missing_component_in_a_method_call -> bug_16226/error_when_importing_technique_with_missing_component_in_a_method_call_pr
From github.com:Normation/ncf
   b406dcb..7c0cae9  branches/rudder/6.0 -> NRM/branches/rudder/6.0
   ab6ca83..d69fa95  master              -> NRM/master
Switched to branch 'branches/rudder/5.0'
Switched to a new branch '5.0_test'
make: *** [Makefile:58: test-common] Error 1

You should run ./qa-test in your repository to make sure it works.
You can also run rudder-dev merge https://github.com/Normation/ncf/pull/1112 --test to test with upmerging.
After this, you can remove the qa: Can't merge ta
-- Your faithful QA (https://ci.normation.com/jenkins/job/merge-accepted-pr/17722/console)

@VinceMacBuche
Copy link
Member Author

Commit modified

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/ncf/pull/1112
-- Your faithful QA
Kant merge: "Two things awe me most, the starry sky above me and the moral law within me."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/17772/console)

@VinceMacBuche
Copy link
Member Author

Commit modified

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/ncf/pull/1112
-- Your faithful QA
Kant merge: "It is beyond a doubt that all our knowledge begins with experience."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/17774/console)

@VinceMacBuche
Copy link
Member Author

OK, squash merging this PR

@VinceMacBuche VinceMacBuche force-pushed the bug_16226/error_when_importing_technique_with_missing_component_in_a_method_call branch from bc9c6c2 to b12ce29 Compare December 1, 2019 23:23
@VinceMacBuche VinceMacBuche merged commit b12ce29 into Normation:branches/rudder/5.0 Dec 1, 2019
@VinceMacBuche
Copy link
Member Author

(fixup to fix invalid tests)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants