Fixes #16645: Command parameter should not be called "Command name" #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,7 +20,7 @@ | |||
| # @description Execute a command | |||
| # @action | |||
| # | |||
| # @parameter command_name Command name | |||
| # @parameter command_name Command to run | |||
There was a problem hiding this comment.
paremeter will still be named "Command name" if you keep command_name
There was a problem hiding this comment.
in fact all parameter names are
replace "_" by " " and uppercase of first character
|
PR updated with a new commit |
VinceMacBuche
approved these changes
Jan 29, 2020
|
OK, squash merging this PR |
Normation-Quality-Assistant
force-pushed
the
bug_16645/command_parameter_should_not_be_called_command_name
branch
from
b7ff865
to
3725c1b
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/16645