Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #17354: remove non-rudder logger from ncf #1194

Merged
merged 1 commit into from
May 12, 2020
Merged

Fixes #17354: remove non-rudder logger from ncf #1194

merged 1 commit into from
May 12, 2020

Conversation

ncharles
Copy link
Member

@ncharles ncharles commented May 7, 2020

@ncharles ncharles requested a review from amousset May 7, 2020 13:48
@ncharles ncharles force-pushed the bug_17354/remove_non_rudder_logger_from_ncf branch from 48ed740 to 6425028 Compare May 7, 2020 13:49
@ncharles
Copy link
Member Author

ncharles commented May 7, 2020

Commit modified

@amousset
Copy link
Member

amousset commented May 8, 2020

keeping the _log_v3 in generic methods would ease upmerge

@ncharles
Copy link
Member Author

we'll always have upmerge issue, won't we? isn't it better to have it now before LTS than after?

@amousset
Copy link
Member

we can keep the log_v3 name (until rudder-lang generated code)

@ncharles
Copy link
Member Author

Commit modified

@ncharles ncharles force-pushed the bug_17354/remove_non_rudder_logger_from_ncf branch from 6425028 to 79e0937 Compare May 11, 2020 13:00
@ncharles ncharles force-pushed the bug_17354/remove_non_rudder_logger_from_ncf branch from 79e0937 to e0ce086 Compare May 11, 2020 13:02
@ncharles
Copy link
Member Author

Commit modified

@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 5d54832 into Normation:branches/rudder/6.1 May 12, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amousset amousset amousset approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncharles @amousset @Normation-Quality-Assistant