Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #18178: Unparsable techniques when there are error in cf-promises (cf-promises outputs error in stdout) #1240

Conversation

VinceMacBuche
Copy link
Member

@Normation-Quality-Assistant
Copy link
Contributor

This PR breaks qa-test

-- stdout -- 
Branch 'branches/rudder/6.1' set up to track remote branch 'branches/rudder/6.1' from 'NRM'.
Your branch is up to date with 'NRM/branches/rudder/6.1'.
Already up to date.
Already up to date.
[...]
  File "/var/lib/jenkins/jobs/merge-accepted-pr/workspace/repos/ncf/tools/ncf.py", line 83, in check_output
    if line.startsWith("{"):
AttributeError: 'unicode' object has no attribute 'startsWith'

----------------------------------------------------------------------
Ran 16 tests in 1.736s

FAILED (errors=16)
make: *** [Makefile:53: test-common] Error 1

You should run ./qa-test in your repository to make sure it works.
You can also run rudder-dev merge https://github.com/Normation/ncf/pull/1240 --test to test with upmerging.
After this, you can remove the qa: Can't merge ta
-- Your faithful QA (https://ci.normation.com/jenkins/job/merge-accepted-pr/29776/console)

@amousset
Copy link
Member

python 💥

@amousset
Copy link
Member

what an enfer

@VinceMacBuche
Copy link
Member Author

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR breaks qa-test

-- stdout -- 
Branch 'branches/rudder/6.1' set up to track remote branch 'branches/rudder/6.1' from 'NRM'.
Your branch is up to date with 'NRM/branches/rudder/6.1'.
Already up to date.
Your branch is up to date with 'NRM/branches/rudder/6.1'.
[...]
  File "/var/lib/jenkins/jobs/merge-accepted-pr/workspace/repos/ncf/tools/ncf.py", line 332, in parse_technique_methods
    raise NcfError("An error occured while parsing technique '"+technique_file+"'", cause = e)
NcfError: "An error occured while parsing technique '/var/lib/jenkins/jobs/merge-accepted-pr/workspace/repos/ncf/tests/unit/test_technique.cf'"

----------------------------------------------------------------------
Ran 16 tests in 1.802s

FAILED (errors=16)
make: *** [Makefile:53: test-common] Error 1

You should run ./qa-test in your repository to make sure it works.
You can also run rudder-dev merge https://github.com/Normation/ncf/pull/1240 --test to test with upmerging.
After this, you can remove the qa: Can't merge ta
-- Your faithful QA (https://ci.normation.com/jenkins/job/merge-accepted-pr/29779/console)

@VinceMacBuche
Copy link
Member Author

Everything is good python,

Mutable variable, enumerate through index, break in loop, and wonderful splice syntax

python/20

@VinceMacBuche
Copy link
Member Author

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

OK, squash merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant force-pushed the bug_18178/unparsable_techniques_when_there_are_error_in_cf_promises_cf_promises_outputs_error_in_stdout branch from 2d39604 to 10b72ee Compare September 11, 2020 08:30
@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 10b72ee into Normation:branches/rudder/6.1 Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants