Fixes #18313: implement nim package manager #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peckpeck
requested changes
Oct 12, 2020
| # @parameter_constraint provider "allow_empty_string" : true | ||
| # @parameter_constraint provider "select" : [ "", "default", "yum", "apt", "zypper", "zypper_pattern", "slackpkg", "pkg", "ips" ] | ||
| # @parameter_constraint provider "select" : [ "", "default", "yum", "apt", "zypper", "zypper_pattern", "slackpkg", "pkg", "ips", "nimclient" ] |
There was a problem hiding this comment.
Why nimclient and not just nim ?
There was a problem hiding this comment.
because it a nim client and not a nim server
There was a problem hiding this comment.
it is a package type, how can a package type be a client or a server ?
There was a problem hiding this comment.
If you use nim on AIX, you have a server that shares object, and a client that installs it, and the command is literraly "nimclient"
|
package module file is already present in ncf: https://github.com/Normation/ncf/blob/master/tree/10_ncf_internals/modules/packages/nimclient |
amousset
reviewed
Oct 12, 2020
Co-authored-by: Alexis Mousset <contact@amousset.me>
peckpeck
approved these changes
Oct 12, 2020
|
OK, merging this PR |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/18313