Fixes #20884: package state options method breaks "Packages" techniques with new reporting #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_20884/package_state_options_method_breaks_packages_techniques_with_new_reporting
branch
from
8690e4e
to
126538b
Compare
ncharles
reviewed
Mar 12, 2022
| "args" slist => { "${name}", "${version}", "${architecture}", "${provider}", "${state}", "${options}" }; | ||
| "report_param" string => join("_", args); | ||
| "full_class_prefix" string => canonify("package_state_options_${report_param}"); | ||
| "old_class_prefix" string => string_head("${full_class_prefix}", "1000"); |
There was a problem hiding this comment.
this is really confusing to set "old_class_prefix" to the previous class_previous while "class_prefix" is the "old_class_prefix"
Can you use "previous_class_prefix" ?
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_20884/package_state_options_method_breaks_packages_techniques_with_new_reporting
branch
from
126538b
to
5899af1
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_20884/package_state_options_method_breaks_packages_techniques_with_new_reporting
branch
from
5899af1
to
6ce392c
Compare
amousset
reviewed
Mar 15, 2022
tree/20_cfe_basics/common.cf
Outdated
| @@ -114,6 +114,28 @@ body classes classes_generic_two(x,y) | |||
| }; | |||
| } | |||
|
|
|||
| body classes cancel_classes(y) | |||
| { | |||
| cancel_repaired => { "promise_repaired_$(y)", "$(y)_repaired", "$(y)_ok", "$(y)_reached", "$(y)_not_kept" | |||
There was a problem hiding this comment.
there are dusplicates in this list
There was a problem hiding this comment.
plus we already have a tree/30_generic_methods/_classes_cancel.cf method which should do the job
There was a problem hiding this comment.
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_20884/package_state_options_method_breaks_packages_techniques_with_new_reporting
branch
from
6ce392c
to
09f5109
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_20884/package_state_options_method_breaks_packages_techniques_with_new_reporting
branch
from
09f5109
to
a579509
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_20884/package_state_options_method_breaks_packages_techniques_with_new_reporting
branch
from
a579509
to
9f9e85e
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_20884/package_state_options_method_breaks_packages_techniques_with_new_reporting
branch
from
9f9e85e
to
41ede36
Compare
amousset
approved these changes
Mar 16, 2022
…ques with new reporting
|
OK, merging this PR |
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_20884/package_state_options_method_breaks_packages_techniques_with_new_reporting
branch
from
41ede36
to
b680d71
Compare
|
Merged with ugly list |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/20884