Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #22322: file key value parameter in list accepts entries without separator #1381

Merged
merged 1 commit into from Mar 13, 2023
Merged

Fixes #22322: file key value parameter in list accepts entries without separator #1381

merged 1 commit into from Mar 13, 2023

Conversation

ncharles
Copy link
Member

@ncharles ncharles commented Feb 7, 2023

@ncharles
Copy link
Member Author

ncharles commented Feb 7, 2023

PR updated with a new commit

peckpeck
peckpeck approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@peckpeck peckpeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice regex

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/ncf/pull/1381
-- Your faithful QA
Kant merge: "Two things awe me most, the starry sky above me and the moral law within me."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/64786/console)

@peckpeck
Copy link
Member

@ncharles meeds manual merge

@ncharles ncharles added Trigger test Trigger jenkins build and removed Trigger test Trigger jenkins build labels Mar 13, 2023
@ncharles
Copy link
Member Author

OK, squash merging this PR

@ncharles ncharles force-pushed the bug_22322/file_key_value_parameter_in_list_accepts_entries_without_separator branch from 1017f70 to cfb164e Compare March 13, 2023 14:43
@ncharles ncharles merged commit cfb164e into Normation:branches/rudder/7.2 Mar 13, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peckpeck peckpeck peckpeck approved these changes

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
3 participants
@ncharles @Normation-Quality-Assistant @peckpeck