Fixes #5924: Clarify the README (quickstart, etc...) #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me ! |
|
This edit seems perfect for GitHub's README. However, this README is also the main page on http://www.ncf.io... which I'm pretty sure we don't want to change like this (some changes are great - but removing syntax colouring in the main example, is not). Could you please rework this so that these 2 pages are separate? It's probably a simple case of "cp README site/content/index.md" or similar. |
Kegeruneku
force-pushed
the
bug_5924/dev/5924_clarify_readme
branch
2 times, most recently
from
58d7b26
to
3ca14eb
Compare
Kegeruneku
force-pushed
the
bug_5924/dev/5924_clarify_readme
branch
from
3ca14eb
to
bfdbbf5
Compare
|
Updated according to review :) |
|
@Kegeruneku, you should switch the readme and index.md, (ie the syntax highlight was removed from index.md and is still in readme) |
|
This has been done elsewhere, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://www.rudder-project.org/redmine/issues/5924
To be merged in master