Fixes #7195: Canonify in ncf doesn't work like cfengine does #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # to match cfengine behaviour we need to treat utf8 as if it was ascii (see #7195) | ||
| # python2 uses iso strings here, but python3 uses utf8 | ||
| if sys.version_info[0] != 2: | ||
| string = string.encode("utf-8").decode("iso-8859-1") |
There was a problem hiding this comment.
isn't the iso-8859-1 dependant on the machine locale, or user input ?
There was a problem hiding this comment.
this looks really dodgy to me to convert to ise-8859-1
There was a problem hiding this comment.
It is not dependent on the locale.
The "utf-8" is dependent on how ncf builder processes strings. And i'm pretty sure it is always utf8.
The "iso-8859-1" could be any 1 byte encoding, it is here to make sure python3 treats it as a string and not byte array so that we can apply a regex on it.
|
where are the unit tests ? |
peckpeck
force-pushed
the
bug_7195/canonify_in_ncf_doesn_t_work_like_cfengine_does
branch
from
3cac5a8
to
c36a3c1
Compare
|
PR updated |
peckpeck
force-pushed
the
bug_7195/canonify_in_ncf_doesn_t_work_like_cfengine_does
branch
from
c36a3c1
to
cccdf22
Compare
|
PR updated |
|
@peckpeck can you rebase your PR please ? :) |
peckpeck
force-pushed
the
bug_7195/canonify_in_ncf_doesn_t_work_like_cfengine_does
branch
from
cccdf22
to
38bc4da
Compare
|
PR updated |
VinceMacBuche
added a commit
that referenced
this pull request
Sep 29, 2015
…t_work_like_cfengine_does Fixes #7195: Canonify in ncf doesn't work like cfengine does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7195