-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #8154: Printf error messages on Windows Agents #389
Fixes #8154: Printf error messages on Windows Agents #389
Conversation
"splay" string => execresult("/usr/bin/printf '%d' 0x${splay_hex}", "noshell"); | ||
windows:: | ||
"splay" string => execresult(" [Convert]::ToInt32('0x${splay_hex}', 16)", "powershell"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the space at the beginning of the line needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is clearly a typo :/
Commit modified |
3745f8c
to
2fe8415
Compare
# decimal version of the splay integer | ||
!windows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!windows:
-> !windows::
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, this PR is clearly not my best one ...
Commit modified |
2fe8415
to
6030176
Compare
OK, merging this PR |
https://www.rudder-project.org/redmine/issues/8154