Fixes #8270: Missing reporting in "Service ensure running with service path" when the service is not running #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e path" when the service is not running
| @@ -57,7 +57,7 @@ bundle agent service_ensure_running_path(service_name, service_path) | |||
| ifvarclass => "(real_path.service_check_running_${canonified_service_path}_kept)|(!real_path.service_check_running_${canonified_service_name})"; | |||
|
|
|||
| "class copy if not running" | |||
| usebundle => _classes_copy("service_start_${canonified_service_path}", "${class_prefix}"), | |||
| usebundle => _classes_copy("service_start_${canonified_service_name}", "${class_prefix}"), | |||
There was a problem hiding this comment.
Both could exist since depending on the real_path class, service_check_running_ps and service_check_running can be called.
So you should probably copy both.
There was a problem hiding this comment.
I don't see cases where service_start would be called with the path, what do you refer to?
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/8270