Fixes #9230: Define a dry-run lib when default bodies are not supported #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires changes in |
|
Commit modified |
amousset
force-pushed
the
ust_9230/define_a_dry_run_lib_when_default_bodies_are_not_supported
branch
from
9c36d80
to
81dceda
Compare
peckpeck
reviewed
Oct 7, 2016
| @@ -34,6 +54,11 @@ | |||
| # WARNING: * promise type specific dry-run is NOT considered by action bodies, and will be overriden | |||
| # WARNING: when using any action body. | |||
| # WARNING: | |||
| # | |||
| # @parameter mode The dry-run mode, "true" to enable dry-run-mode and "false" to disable it | |||
| # @agent_requirements "capabilities": [ "defaultbody" ] || "agent_version"" >= 3.9 | |||
There was a problem hiding this comment.
This kind of expression is not yet supported
There was a problem hiding this comment.
I know, but we will need it for this. We need to choose the syntax and implement it in list-compatible-inputs.
There was a problem hiding this comment.
It was not implemented because it is very long and complex to implement in standard shell, I hope we can find time to implement it before the end of times
amousset
force-pushed
the
ust_9230/define_a_dry_run_lib_when_default_bodies_are_not_supported
branch
from
81dceda
to
c4f1f63
Compare
|
Commit modified |
|
OK, merging this PR |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/9230