Fixes #10388: Add a generic method that handles using options in package actions #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
amousset
force-pushed
the
ust_10388/add_a_generic_method_that_handles_using_options_in_package_actions
branch
from
2a99c9f
to
8bf2abf
Compare
amousset
force-pushed
the
ust_10388/add_a_generic_method_that_handles_using_options_in_package_actions
branch
from
8bf2abf
to
2ab7304
Compare
|
Commit modified |
peckpeck
reviewed
Apr 25, 2017
| # name old version new version | ||
| # | | | | ||
| # /-------+-------\ /--+--\ /------+-------\ | ||
| match = re.match("^Inst\s+(?P<name>[^\s:]+)(?::\S+)?\s+\[[^\]\s]+\]\s+\((?P<version>\S+)" + | ||
| match = re.match("^Inst\s+(?P<name>[^\s:]+)(?::\S+)?\s+\[[^]\s]+\]\s+\((?P<version>\S+)" + |
There was a problem hiding this comment.
removing this \ seems to be a mistake
There was a problem hiding this comment.
This comes from the CFEngine script we had modified a bit. It does not change the behavior (while a bit less readable).
| # repository(ies) arch (might be optional) | ||
| # | | | ||
| # /--+-\ /---------+---------\ | ||
| "\s+[^[)]*(\s\[(?P<arch>[^]\s]+)\])?\).*", line) |
There was a problem hiding this comment.
even if not mandatory, there should be a \ before the inside [
|
OK, merging this PR |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/10388