Fixes #11999: Wrong detection of package provider on debian for package_* method #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Jan 17, 2018
tree/20_cfe_basics/package_lib.cf
Outdated
| @@ -75,7 +75,7 @@ bundle agent ncf_package(name, version, architecture, provider, state, options) | |||
|
|
|||
| # Select the right package manager | |||
| # The default one has already been selected if needed using mackage_module_knowledge | |||
| "use_apt_provider" expression => strcmp("apt", "${provider}"); | |||
| "use_apt_provider" expression => strcmp("apt_get", "${provider}"); | |||
There was a problem hiding this comment.
When specifying the provider in the generic method the parameter is apt, so we should detect both as valid apt provider.
There was a problem hiding this comment.
you are totally right ! thank you
|
Commit modified |
ncharles
force-pushed
the
bug_11999/wrong_detection_of_package_provider_on_debian_for_package_method
branch
from
eb92c84
to
a4291f9
Compare
|
OK, merging this PR |
|
OK, merging this PR |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/11999