Fixes #11766: Rename class to condition in the interface #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not merge for now, also updating the doc |
amousset
force-pushed
the
arch_11766/rename_class_to_condition_in_the_interface
branch
from
74a57d0
to
58d8b0f
Compare
|
Commit modified |
|
Ready for review! |
|
Commit modified |
amousset
force-pushed
the
arch_11766/rename_class_to_condition_in_the_interface
branch
from
58d8b0f
to
45d65b8
Compare
|
This PR needs a rebase |
|
Commit modified |
amousset
force-pushed
the
arch_11766/rename_class_to_condition_in_the_interface
branch
from
45d65b8
to
b1613aa
Compare
|
@peck done! |
|
PR rebased |
peckpeck
approved these changes
Mar 20, 2018
|
OK, merging this PR |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/11766