Fixes #15054: Manage technique resource in technique editor using a file manager #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinceMacBuche
force-pushed
the
ust_15054/manage_technique_resource_in_technique_editor_using_a_file_manager
branch
from
edcbf29
to
ef94cb7
Compare
|
Commit modified |
amousset
reviewed
Jun 11, 2019
tools/ncf.py
Outdated
| @@ -548,6 +548,8 @@ def generate_technique_content(technique, methods): | |||
| content.append('{') | |||
|
|
|||
|
|
|||
| content.append(' vars:') | |||
| content.append(' "resource_dir" string => "${this.promise_dir}/resources";') | |||
There was a problem hiding this comment.
I'd use resources in the name variable too for consistency
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_15054/manage_technique_resource_in_technique_editor_using_a_file_manager
branch
from
ef94cb7
to
0a5308c
Compare
VinceMacBuche
force-pushed
the
ust_15054/manage_technique_resource_in_technique_editor_using_a_file_manager
branch
from
0a5308c
to
1f7ff15
Compare
|
Commit modified |
fanf
approved these changes
Jul 5, 2019
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/15054