-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #15054: Manage technique resource in technique editor using a file manager #984
Conversation
edcbf29
to
ef94cb7
Compare
Commit modified |
tools/ncf.py
Outdated
@@ -548,6 +548,8 @@ def generate_technique_content(technique, methods): | |||
content.append('{') | |||
|
|||
|
|||
content.append(' vars:') | |||
content.append(' "resource_dir" string => "${this.promise_dir}/resources";') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use resources in the name variable too for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done :)
Commit modified |
ef94cb7
to
0a5308c
Compare
0a5308c
to
1f7ff15
Compare
Commit modified |
This PR is not mergeable to upper versions. |
OK, merging this PR |
https://issues.rudder.io/issues/15054