Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #15110: We should test sles and suse classes in ncf tests #988

Closed
wants to merge 0 commits into from
Closed

Fixes #15110: We should test sles and suse classes in ncf tests #988

wants to merge 0 commits into from

Conversation

Fdall
Copy link
Contributor

@Fdall Fdall commented Jun 20, 2019

@ncharles
Copy link
Member

why not defining a sles class in the test template ?

@Fdall Fdall force-pushed the bug_15110/we_should_test_sles_and_suse_classes_in_ncf_tests branch from a87501f to c3c66a2 Compare July 2, 2019 15:31
@Fdall
Copy link
Contributor Author

Fdall commented Jul 2, 2019

Commit modified

@Fdall Fdall force-pushed the bug_15110/we_should_test_sles_and_suse_classes_in_ncf_tests branch from c3c66a2 to c75c3d4 Compare July 2, 2019 15:32
@Fdall
Copy link
Contributor Author

Fdall commented Jul 2, 2019

Commit modified

@Fdall
Copy link
Contributor Author

Fdall commented Jul 2, 2019

PR rebased

@Fdall Fdall closed this Jul 2, 2019
@Fdall Fdall force-pushed the bug_15110/we_should_test_sles_and_suse_classes_in_ncf_tests branch from c75c3d4 to 350fcde Compare July 2, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fdall @ncharles