Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #10142: Extend variable_dict_from_file to allow reading yaml and csv files #998

Merged
merged 2 commits into from
Jul 9, 2019
Merged

Fixes #10142: Extend variable_dict_from_file to allow reading yaml and csv files #998

merged 2 commits into from
Jul 9, 2019

Conversation

amousset
Copy link
Member

@amousset amousset commented Jul 4, 2019

@amousset amousset mentioned this pull request Jul 4, 2019
Closed
@amousset amousset force-pushed the ust_10142/extend_variable_dict_from_file_to_allow_reading_yaml_and_csv_files branch from 3de3371 to 4ab31c9 Compare July 4, 2019 14:06
@amousset
Copy link
Member Author

amousset commented Jul 4, 2019

Commit modified

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/ncf/pull/998
-- Your faithful QA
Kant merge: "Thoughts without content are empty, intuitions without concepts are blind."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/12068/console)

@amousset
Copy link
Member Author

amousset commented Jul 9, 2019

OK, merging this PR

@amousset amousset merged commit 4ab31c9 into Normation:branches/rudder/5.0 Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peckpeck peckpeck peckpeck approved these changes

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
3 participants
@amousset @Normation-Quality-Assistant @peckpeck