Fixes #5791: Implementation of a command line for rudder agent #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peckpeck
force-pushed
the
dev_5791/implementation_of_a_command_line_for_rudder_agent
branch
2 times, most recently
from
25e26f9
to
70a3e3e
Compare
| @@ -0,0 +1,3 @@ | |||
| #!/bin/sh | |||
| # @description re-enable a disabled rudder-agent | |||
| rm -f /opt/rudder/etc/disable-agent | |||
There was a problem hiding this comment.
Shouldn't the enable command also check that cf-execd is running and start it if not? Otherwise, it's not really enabled, or it will be but only after some random delay...
There was a problem hiding this comment.
It will be run after 5mn by cron if the user forgets to run it.
I think enable just mean enable and not run, but we can add a parameter for that.
|
Aside from the comments above, this looks AWESOME! |
peckpeck
force-pushed
the
dev_5791/implementation_of_a_command_line_for_rudder_agent
branch
from
70a3e3e
to
c30431e
Compare
|
@jooooooon PR updated |
| echo " Available commands:" | ||
| for file in `cd "${BASEDIR}"; find . -type f -name "${role}-*" | sort` | ||
| do | ||
| doc=`grep "# @description" "${BASEDIR}/${file}" | sed -e "s/#[ \t]*@description[ \t]*//"` |
There was a problem hiding this comment.
I actually meant to change the regex in both places - also in the grep :)
peckpeck
force-pushed
the
dev_5791/implementation_of_a_command_line_for_rudder_agent
branch
from
c30431e
to
8088292
Compare
|
Updated |
jooooooon
added a commit
that referenced
this pull request
Nov 24, 2014
…and_line_for_rudder_agent Fixes #5791: Implementation of a command line for rudder agent
peckpeck
deleted the
dev_5791/implementation_of_a_command_line_for_rudder_agent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://www.rudder-project.org/redmine/issues/5791