Fixes #13405: Improve command "rudder server upgrade-techniques" #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
force-pushed
the
bug_13405/improve_command_rudder_server_upgrade_techniques
branch
from
fe650d9
to
55a514b
Compare
|
Commit modified |
peckpeck
reviewed
Sep 6, 2018
| OPTIONS=uiofc:a:s | ||
| LONGOPTS=upgrade,initial,override,force,commit:,autoupdate-technique-library:,show | ||
|
|
||
| # Use pipe to be able to get exit code, without messages |
There was a problem hiding this comment.
The explanation is :
- Use ! to avoid failing with set -e
- Use $PIPESTATUS to get the right return code even with !
ncharles
force-pushed
the
bug_13405/improve_command_rudder_server_upgrade_techniques
branch
from
55a514b
to
ad184e2
Compare
|
Commit modified |
peckpeck
approved these changes
Sep 6, 2018
ncharles
force-pushed
the
bug_13405/improve_command_rudder_server_upgrade_techniques
branch
from
ad184e2
to
22b659f
Compare
|
Commit modified |
ncharles
force-pushed
the
bug_13405/improve_command_rudder_server_upgrade_techniques
branch
from
22b659f
to
b5e2922
Compare
|
Commit modified |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/13405