Fixes #14831: Clean up rudder agent check #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still some TODO |
|
Commit modified |
2 similar comments
|
Commit modified |
|
Commit modified |
amousset
approved these changes
May 7, 2019
amousset
reviewed
May 7, 2019
share/commands/agent-check
Outdated
| # If we are using TCP, we cannot stop postgresql otherwise all infra can go down - but we can stop rudder-jetty and disable rudder agent | ||
| use_tcp=0 | ||
| NB_TCP=$(grep -r "TCP" /var/rudder/cfengine-community/inputs/promises.cf | wc -l) | ||
| if [ 2 -eq "${NB_TCP}" ]; then |
There was a problem hiding this comment.
Isn't this present in rudder.json?
There was a problem hiding this comment.
It is, could you use it instead? It will be much more robust.
amousset
reviewed
May 7, 2019
| check_and_fix_rudder_uuid | ||
|
|
||
| # Once for rudder's cfengine | ||
| if [ -e "${RUDDER_CFE_DIR}/bin/cf-agent" ] |
|
Commit modified |
|
OK, squash merging this PR |
Normation-Quality-Assistant
force-pushed
the
arch_14831/clean_up_rudder_agent_check
branch
from
81270bb
to
5c48a02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/14831