-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #14831: Clean up rudder agent check #214
Fixes #14831: Clean up rudder agent check #214
Conversation
Still some TODO |
Commit modified |
2 similar comments
Commit modified |
Commit modified |
share/commands/agent-check
Outdated
# If we are using TCP, we cannot stop postgresql otherwise all infra can go down - but we can stop rudder-jetty and disable rudder agent | ||
use_tcp=0 | ||
NB_TCP=$(grep -r "TCP" /var/rudder/cfengine-community/inputs/promises.cf | wc -l) | ||
if [ 2 -eq "${NB_TCP}" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this present in rudder.json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is, could you use it instead? It will be much more robust.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
com
check_and_fix_rudder_uuid | ||
|
||
# Once for rudder's cfengine | ||
if [ -e "${RUDDER_CFE_DIR}/bin/cf-agent" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😮
Commit modified |
OK, squash merging this PR |
81270bb
to
5c48a02
Compare
https://issues.rudder.io/issues/14831