Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #15506: Change rudder agent bash autocomplete file to add rudder-pkg completion #245

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Fixes #15506: Change rudder agent bash autocomplete file to add rudder-pkg completion #245

merged 1 commit into from
Aug 20, 2019

Conversation

Fdall
Copy link
Contributor

@Fdall Fdall commented Aug 19, 2019

@Fdall
Copy link
Contributor Author

Fdall commented Aug 19, 2019

PR updated with a new commit

peckpeck
peckpeck reviewed Aug 19, 2019
View reviewed changes
etc/bash_completion.d/rudder.sh Outdated
if [ $COMP_CWORD -ge 1 ]; then
case ${COMP_WORDS[1]} in
package)
PKG_FILE="rudder-pkg.sh"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need an absolute path here since you don't know the current directory

@Fdall Fdall force-pushed the ust_15506/change_rudder_agent_bash_autocomplete_file_to_add_rudder_pkg_completion branch from 77a5f04 to 84a76bf Compare August 19, 2019 16:49
@Fdall
Copy link
Contributor Author

Fdall commented Aug 19, 2019

Commit modified

@Fdall
Copy link
Contributor Author

Fdall commented Aug 20, 2019

PR updated with a new commit

@Fdall Fdall requested a review from peckpeck August 20, 2019 10:07
@Normation-Quality-Assistant
Copy link

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-agent/pull/245
-- Your faithful QA
Kant merge: "Thoughts without content are empty, intuitions without concepts are blind."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/13894/console)

@Fdall
Copy link
Contributor Author

Fdall commented Aug 20, 2019

OK, squash merging this PR

1 similar comment
@Fdall
Copy link
Contributor Author

Fdall commented Aug 20, 2019

OK, squash merging this PR

@Normation-Quality-Assistant
Copy link

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-agent/pull/245
-- Your faithful QA
Kant merge: "In law a man is guilty when he violates the rights of others. In ethics he is guilty if he only thinks of doing so."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/13903/console)

@Fdall
Copy link
Contributor Author

Fdall commented Aug 20, 2019

PR rebased

@Fdall
Copy link
Contributor Author

Fdall commented Aug 20, 2019

PR rebased

@Normation-Quality-Assistant
Copy link

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-agent/pull/245
-- Your faithful QA
Kant merge: "Live your life as though your every act were to become a universal law."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/13906/console)

@Fdall
Copy link
Contributor Author

Fdall commented Aug 20, 2019

PR rebased

@Fdall Fdall force-pushed the ust_15506/change_rudder_agent_bash_autocomplete_file_to_add_rudder_pkg_completion branch from 020ea51 to c3787d3 Compare August 20, 2019 15:12
@Normation-Quality-Assistant
Copy link

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-agent/pull/245
-- Your faithful QA
Kant merge: "Happiness is not an ideal of reason, but of imagination."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/13908/console)

@Fdall
Copy link
Contributor Author

Fdall commented Aug 20, 2019

OK, merging this PR

@Fdall Fdall merged commit c3787d3 into Normation:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peckpeck peckpeck peckpeck approved these changes

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
3 participants
@Fdall @Normation-Quality-Assistant @peckpeck