Fixes #16128: We should not start agent daemons outside of the service #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
2 similar comments
|
PR updated with a new commit |
|
PR updated with a new commit |
peckpeck
reviewed
Nov 6, 2019
| killall cf-serverd | ||
| elif type pidof > /dev/null 2> /dev/null; then | ||
| kill $(pidof cf-serverd 2>/dev/null) | ||
| if type systemctl >/dev/null 2>&1; then |
There was a problem hiding this comment.
Isn't it always the case on server distro ?
|
PR updated with a new commit |
peckpeck
approved these changes
Nov 13, 2019
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
amousset
force-pushed
the
bug_16128/we_should_not_start_agent_daemons_outside_of_the_service
branch
from
f0ecdec
to
a122d7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/16128