Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #19178: Add rudder http client to rudder agent #334

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Fixes #19178: Add rudder http client to rudder agent #334

merged 1 commit into from
Apr 28, 2021

Conversation

peckpeck
Copy link
Member

@peckpeck peckpeck requested a review from amousset April 22, 2021 14:52
@peckpeck
Copy link
Member Author

PR updated with a new commit

amousset
amousset reviewed Apr 23, 2021
View reviewed changes
bin/rudder-client Outdated
SECOPTS="--insecure"
fi

# get server authentication from russer.json if available and not overridden
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# get server authentication from russer.json if available and not overridden
# get server authentication from rudder.json if available and not overridden

@Normation-Quality-Assistant
Copy link

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-agent/pull/334
-- Your faithful QA
Kant merge: "Live your life as though your every act were to become a universal law."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/38011/console)

@peckpeck
Copy link
Member Author

PR updated with a new commit

@Normation-Quality-Assistant
Copy link

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-agent/pull/334
-- Your faithful QA
Kant merge: "To be is to do."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/38201/console)

@peckpeck
Copy link
Member Author

OK, squash merging this PR

@peckpeck peckpeck force-pushed the arch_19178/add_rudder_http_client_to_rudder_agent branch from 5d52234 to c7909a9 Compare April 28, 2021 15:37
@peckpeck peckpeck merged commit c7909a9 into Normation:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amousset amousset amousset approved these changes

Assignees
No one assigned
Labels
qa: Can't merge Trigger test
Projects
None yet
Milestone
No milestone
3 participants
@peckpeck @Normation-Quality-Assistant @amousset