Fixes #8187: rudder remote-run should allow running for a group of nodes #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,7 +6,7 @@ | |||
| # @man + | |||
| # @man *Arguments*: | |||
| # @man + | |||
| # @man *node*: IP or hostname of the target node | |||
| # @man *node*: IP or hostname of the target node 'all' for all nodes of the server | |||
There was a problem hiding this comment.
You're missing a comma or the word "or" to separate these two options here
|
This looks really great. I love the power yet simplicity of it! I've made some feedback on the code, mostly minor. |
peckpeck
force-pushed
the
ust_8187/rudder_remote_run_should_allow_running_for_a_group_of_nodes
branch
from
6f7a985
to
808edc8
Compare
|
PR updated |
| @@ -19,7 +21,7 @@ simple_api_call() { | |||
| then | |||
| printf "${WHITE}${curl_command}${NORMAL}\n" | |||
| fi | |||
| result=`eval ${curl_command}` | |||
| result=`eval ${DOWNLOAD_COMMAND} \"${url}\"` | |||
There was a problem hiding this comment.
Since you already have this value in curl_command, why not just use it?
There was a problem hiding this comment.
Yes, a copy/paste mistake when restoring curl_command
|
Great stuff. Thanks for the quick update. Merging! |
peckpeck
deleted the
ust_8187/rudder_remote_run_should_allow_running_for_a_group_of_nodes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/8187