Fixes #8196: Tell if we are on a relay in rudder agent info #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see the value in displaying whether a machine is a relay or not. However, this method seems a bit flaky - just checking if a directory exists. Don't we have a more reliable method? I know that as of recent versions there is a "rudder-server-relay" package. We could start by checking for that, maybe, and go back to directories as a fallback? |
|
/var/rudder/share is created by the relay promises and /var/rudder/inventories/incoming is created by the relay package Checking the package is hard since we are in a shell script and we need to first detect the os. |
| ROLES="${ROLES}, rudder-relay" | ||
| elif [ -d /var/rudder/inventories/incoming ] | ||
| then | ||
| ROLES="${ROLES}, rudder-relay (not registered)" |
There was a problem hiding this comment.
Currently, it looks to me as if this will display a "rudder-relay" role on root servers too. Surely we should protect against this?
|
PR updated |
peckpeck
force-pushed
the
bug_8196/tell_if_we_are_on_a_relay_in_rudder_agent_info
branch
from
f21022d
to
8d5a178
Compare
peckpeck
deleted the
bug_8196/tell_if_we_are_on_a_relay_in_rudder_agent_info
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/8196