Fixes #7824: Add a -u option to rudder agent run to run an update before the run #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -83,4 +90,8 @@ if [ -e /opt/rudder/etc/disable-agent ]; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| if [ "${UPDATE}" = "true" ]; then | |||
There was a problem hiding this comment.
You should reuse the provided options, otherwise you would break user expectations.
There was a problem hiding this comment.
I think you should add raw and multiline options to UPDATE_OPTIONS since they are formatting options too
There was a problem hiding this comment.
I can do but agent-update doesn't support them, so surely it will just break?
jooooooon
force-pushed
the
ust_7824/add_a_u_option_to_rudder_agent_run_to_run_an_update_before_the_run
branch
from
213890d
to
e6a6836
Compare
|
PR rebased |
|
I don't see any change, was it just a rebase ? |
Yes, just a rebase so far. More changes coming. Sorry for the noise.Sent from Kaiten Mail. Please excuse my brevity. |
|
Yes that's the reason I changed the "amend" comment in rudder-dev to be different from the "rebase" comment, but i'm not yet sure if people updated it or not. |
jooooooon
force-pushed
the
ust_7824/add_a_u_option_to_rudder_agent_run_to_run_an_update_before_the_run
branch
from
e6a6836
to
90002b4
Compare
|
Commit modified |
|
I also update my rudder-dev, FYI |
|
Good, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7824