Fixes #15578: Add rudder-api-client to the rudder packages #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peckpeck
reviewed
Aug 26, 2019
Makefile
Outdated
| DESTDIR = $(CURDIR)/target | ||
|
|
||
| build: | ||
| mkdir -p $(DESTDIR) |
There was a problem hiding this comment.
This should be in install not in build
peckpeck
reviewed
Aug 26, 2019
Makefile
Outdated
|
|
||
| RUDDER_VERSION_TO_PACKAGE = | ||
| RUDDER_MAJOR_VERSION := $(shell echo ${RUDDER_VERSION_TO_PACKAGE} | cut -d'.' -f 1-2) | ||
| PYTHON = python3 |
|
PR updated with a new commit |
|
PR updated with a new commit |
peckpeck
approved these changes
Aug 28, 2019
|
OK, squash merging this PR |
Normation-Quality-Assistant
force-pushed
the
ust_15578/add_rudder_api_client_to_the_rudder_packages
branch
from
3df3d20
to
c00c752
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/15578