Fixes #18153: rudder-api-client install a non fonctionning rudder-cli #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peckpeck
reviewed
Sep 1, 2020
cli/rudder-cli
Outdated
|
|
||
| requests.packages.urllib3.disable_warnings(requests.packages.urllib3.exceptions.InsecureRequestWarning) | ||
| import urllib3 | ||
| urllib3.disable_warnings() |
There was a problem hiding this comment.
You have to do both in a try catch because request can use either one depending on situaion
There was a problem hiding this comment.
we do only the later in ncf, i figured it would be safe
There was a problem hiding this comment.
that's why we still have many unsecure request warnings log on some servers
|
PR updated with a new commit |
VinceMacBuche
approved these changes
Sep 1, 2020
|
OK, squash merging this PR |
Normation-Quality-Assistant
force-pushed
the
bug_18153/rudder_api_client_install_a_non_fonctionning_rudder_cli
branch
from
5237114
to
9bcd4b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/18153