Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #8822: Missing BuildRequires for rudder-agent : pam-devel #1006

Conversation

amousset
Copy link
Member

@amousset amousset commented Aug 5, 2016

@amousset amousset force-pushed the bug_8822/missing_buildrequires_for_rudder_agent_pam_devel branch from da8eb9d to db26d90 Compare August 5, 2016 09:45
@amousset
Copy link
Member Author

amousset commented Aug 5, 2016

Commit modified

@amousset
Copy link
Member Author

ping @jooooooon

@jooooooon
Copy link
Member

Ah, sorry, I should have answered this earlier. I just don't understand this - we have been building the agent on 2.11 for years, why would we need a new BuildRequires now?

The ticket doesn't help me understand the context either :)

@amousset
Copy link
Member Author

It is installed on every builder because of https://github.com/Normation/rudder-packages/blob/master/rudder-agent/SOURCES/.dependencies, and also in the requirements for the deb package, but missing from the spec file.

@jooooooon
Copy link
Member

Ah, I see! Thanks for explaining. For future reference, this is exactly what should be written in the ticket itself.

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-packages/pull/1006
-- Your faithful QA

@amousset
Copy link
Member Author

OK, merging this PR

@amousset amousset merged commit db26d90 into Normation:branches/rudder/2.11 Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants