Fixes #8837: Makke uuidgen a single point of uuid generation #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peckpeck
force-pushed
the
bug_8837/makke_uuidgen_a_single_point_of_uuid_generation
branch
from
8e8bd39
to
cbfdfb1
Compare
|
Commit modified |
peckpeck
force-pushed
the
bug_8837/makke_uuidgen_a_single_point_of_uuid_generation
branch
from
cbfdfb1
to
a054f16
Compare
|
Commit modified |
1 similar comment
|
Commit modified |
peckpeck
force-pushed
the
bug_8837/makke_uuidgen_a_single_point_of_uuid_generation
branch
2 times, most recently
from
e7dac95
to
2813ce3
Compare
|
Commit modified |
| setfacl -R -k /var/rudder/ | ||
| fi | ||
| fi | ||
|
|
||
| # launch rudder agent check script, it will generate an UUID on first install or repair it if needed | ||
| nohup /opt/rudder/bin/check-rudder-agent >/dev/null 2>/dev/null & | ||
| ${RUDDER_CMD} agent check >> ${LOG_FILE} 1>&1 |
There was a problem hiding this comment.
Because it is not needed (agent check is quick) and if the check fails, i means the agent has failed to install properly, so we should keep its result in the postinstall
peckpeck
force-pushed
the
bug_8837/makke_uuidgen_a_single_point_of_uuid_generation
branch
from
2813ce3
to
c01c2bc
Compare
|
Commit modified |
|
Looks good to me |
peckpeck
force-pushed
the
bug_8837/makke_uuidgen_a_single_point_of_uuid_generation
branch
from
c01c2bc
to
5b14b8f
Compare
|
Commit modified |
|
OK, merging this PR |
peckpeck
deleted the
bug_8837/makke_uuidgen_a_single_point_of_uuid_generation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/8837