-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #8837: Makke uuidgen a single point of uuid generation #1039
Fixes #8837: Makke uuidgen a single point of uuid generation #1039
Conversation
8e8bd39
to
cbfdfb1
Compare
Commit modified |
cbfdfb1
to
a054f16
Compare
Commit modified |
1 similar comment
Commit modified |
e7dac95
to
2813ce3
Compare
Commit modified |
setfacl -R -k /var/rudder/ | ||
fi | ||
fi | ||
|
||
# launch rudder agent check script, it will generate an UUID on first install or repair it if needed | ||
nohup /opt/rudder/bin/check-rudder-agent >/dev/null 2>/dev/null & | ||
${RUDDER_CMD} agent check >> ${LOG_FILE} 1>&1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing the nohup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it is not needed (agent check is quick) and if the check fails, i means the agent has failed to install properly, so we should keep its result in the postinstall
2813ce3
to
c01c2bc
Compare
Commit modified |
Looks good to me |
c01c2bc
to
5b14b8f
Compare
Commit modified |
OK, merging this PR |
https://www.rudder-project.org/redmine/issues/8837