Fixes #9095: Use a 2 steps download in rudder agent makefile #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooooooon
reviewed
Sep 21, 2016
| @@ -37,24 +37,31 @@ INSTALL_DIR = $(DESTDIR)$(RUDDER_DIR) | |||
| TRY_LDFLAGS=-pie -Wl,-z,relro -Wl,-z,now | |||
| TRY_CFLAGS=-fPIE -fstack-protector | |||
|
|
|||
| # Autodetect wget or curl or curl usage and proxy configuration | |||
| # GENERIC_GET: do note remove this line | |||
| # If you change this code, change all the places where you can find this tag too. | ||
| # It is duplicated because it is the code that is used to manage dependency | ||
| # to other repositories, hence allowing deduplication of other code. | ||
| # Autodetect wget or curl usage and proxy configuration |
| GET_OPT = --wget | ||
| CPAN_OPT = --wget | ||
| endif | ||
| endif | ||
| GET=get() { $(_GET) "$$1.part" "$$2" && mv "$$1.part" "$$1"; }; get |
There was a problem hiding this comment.
Could you add an example of how this will be called to the "doc" comment above?
|
Commit modified |
peckpeck
force-pushed
the
arch_9095/use_a_2_steps_download_in_rudder_agent_makefile
branch
from
6e651b8
to
e46892c
Compare
|
looks good now |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/9095