-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #9209: Broken rpm agent builds in 4.0 #1093
Fixes #9209: Broken rpm agent builds in 4.0 #1093
Conversation
WIP, do not merge for now |
5b4adb6
to
e71d110
Compare
Commit modified |
@Kegeruneku Ready for review! |
@@ -166,6 +166,10 @@ ifneq (true,$(NO_LDSO)) | |||
$(INSTALL) -m 644 rudder.conf $(DESTDIR)/etc/ld.so.conf.d/ | |||
endif | |||
|
|||
# Install /etc/bash_completion.d/rudder in order to autocomplete rudder commands | |||
mkdir -p $(DESTDIR)/etc/bash_completion.d | |||
$(INSTALL) -m 644 rudder.conf $(DESTDIR)/etc/bash_completion.d/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You sure this is the right file ??? rudder.conf is also installed in ld.so.conf...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, the path was totally wrong...
Commit modified |
e71d110
to
1742bc1
Compare
Nice job |
OK, merging this PR |
https://www.rudder-project.org/redmine/issues/9209