Fixes #9209: Broken rpm agent builds in 4.0 #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP, do not merge for now |
amousset
force-pushed
the
bug_9209/broken_rpm_agent_builds_in_4_0
branch
from
5b4adb6
to
e71d110
Compare
|
Commit modified |
|
@Kegeruneku Ready for review! |
Kegeruneku
reviewed
Oct 4, 2016
| @@ -166,6 +166,10 @@ ifneq (true,$(NO_LDSO)) | |||
| $(INSTALL) -m 644 rudder.conf $(DESTDIR)/etc/ld.so.conf.d/ | |||
| endif | |||
|
|
|||
| # Install /etc/bash_completion.d/rudder in order to autocomplete rudder commands | |||
| mkdir -p $(DESTDIR)/etc/bash_completion.d | |||
| $(INSTALL) -m 644 rudder.conf $(DESTDIR)/etc/bash_completion.d/ | |||
There was a problem hiding this comment.
You sure this is the right file ??? rudder.conf is also installed in ld.so.conf...
There was a problem hiding this comment.
Indeed, the path was totally wrong...
|
Commit modified |
amousset
force-pushed
the
bug_9209/broken_rpm_agent_builds_in_4_0
branch
from
e71d110
to
1742bc1
Compare
|
Nice job |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/9209