Fixes #9382: Change the Rudder version in the sources to be substituted in the packaging script #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peckpeck
reviewed
Oct 17, 2016
| @@ -60,6 +61,9 @@ localdepends: ./rudder-sources ./maven/bin/mvn ./rudder-users.xml ./rudder-doc . | |||
| tar -xjf rudder-sources.tar.bz2 | |||
| mv rudder-sources-*/ rudder-sources/ | |||
|
|
|||
| # Change rudder version displayed in the Web UI | |||
| sed -i "s%PACKAGING_RUDDER_VERSION%Rudder ${RUDDER_VERSION_TO_PACKAGE}%" rudder-sources/${HOMEPAGEPATH} | |||
There was a problem hiding this comment.
We should have a kind of tag delimiter like < > or &xx&
Moreover we should replace the tag with the version only, because if we want to change the text we should only have to modify the original html file.
amousset
force-pushed
the
ust_9382/change_the_rudder_version_in_the_sources_to_be_substituted_in_the_packaging_script
branch
from
783e6d7
to
b918a08
Compare
|
Commit modified |
1 similar comment
|
Commit modified |
amousset
force-pushed
the
ust_9382/change_the_rudder_version_in_the_sources_to_be_substituted_in_the_packaging_script
branch
from
b918a08
to
19b1042
Compare
|
Commit modified |
amousset
force-pushed
the
ust_9382/change_the_rudder_version_in_the_sources_to_be_substituted_in_the_packaging_script
branch
from
19b1042
to
57c27c4
Compare
…ed in the packaging script
|
Commit modified |
amousset
force-pushed
the
ust_9382/change_the_rudder_version_in_the_sources_to_be_substituted_in_the_packaging_script
branch
from
57c27c4
to
ffb9610
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/9382